HyukjinKwon commented on PR #47705: URL: https://github.com/apache/spark/pull/47705#issuecomment-2283061812
> In fact, we may not be able to guarantee that the connect-client-jvm module will always only have one provided scope dependency like ammonite. If in the future, more dependencies with the provide scope are added to the connect-client-jvm module, will we need to add more configurations similar to what is currently done for ammonite in the assembly module? BTW `connect-client-jvm` would very likely have only one `ammonite` provided dependency in the future too. It should have all dependencies shaded otherwise so the end users can easily use. However, yeah I guess that this is less future proven. I am thinking about removing `ammonite` away, then actually we could remove the whole this stuff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
