LuciferYang commented on code in PR #47701:
URL: https://github.com/apache/spark/pull/47701#discussion_r1713200194
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -2378,6 +2378,8 @@ class DataSourceV2SQLSuiteV1Filter
val t = "testcat.ns1.ns2.tbl"
withTable(t) {
spark.sql(s"CREATE TABLE $t (id bigint, data string) USING foo")
+ checkAnswer(sql(s"SHOW COLUMNS FROM $t IN testcat.ns1.ns2"),
Seq(Row("id"), Row("data")))
Review Comment:
I apologize for not having a clear understanding of the background before
and providing misleading guidance.
If this is a followup to SPARK-49078, then indeed we should only clean up
`showColumnsNotSupportedForV2TablesError` in this PR and add these two new test
checks.
However, for these two new test checks, we should modify the PR title and
description to make them more relevant.
For other unused methods in `QueryCompilationErrors`, they should be
addressed in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
