davidm-db commented on code in PR #47423:
URL: https://github.com/apache/spark/pull/47423#discussion_r1713679482
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -212,10 +229,37 @@ class AstBuilder extends DataTypeAstBuilder
.map { s =>
SingleStatement(parsedPlan = visit(s).asInstanceOf[LogicalPlan])
}.getOrElse {
- visitChildren(ctx).asInstanceOf[CompoundPlanStatement]
+ val stmt = Option(ctx.beginEndCompoundBlock()).
+ getOrElse(Option(ctx.declareHandler()).
+ getOrElse(Option(ctx.declareCondition()).
+ getOrElse(ctx.ifElseStatement())))
+ visit(stmt).asInstanceOf[CompoundPlanStatement]
}
}
+ override def visitConditionValue(ctx: ConditionValueContext): String = {
+ Option(ctx.multipartIdentifier()).map(_.getText)
+ .getOrElse(ctx.stringLit().getText).replace("'", "")
+ }
+
+ override def visitConditionValueList(ctx: ConditionValueListContext):
Seq[String] = {
+ Option(ctx.SQLEXCEPTION()).map(_ => Seq("SQLEXCEPTION")).getOrElse {
+ Option(ctx.NOT()).map(_ => Seq("NOT FOUND")).getOrElse {
+ val buff = ListBuffer[String]()
+ val seen = scala.collection.mutable.Set[String]()
+ ctx.conditionValues.forEach { conditionValue =>
+ val elem = visit(conditionValue).asInstanceOf[String]
+ if (seen(elem)) {
+ throw
SqlScriptingErrors.duplicateSqlStateForSameHandler(CurrentOrigin.get, elem)
+ }
+ buff += elem
+ seen += elem
+ }
+ buff.toSeq
Review Comment:
can't we use `seen.toSeq` here or some variant of it and remove `buff`
completely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
