amaliujia commented on code in PR #47723:
URL: https://github.com/apache/spark/pull/47723#discussion_r1715737358
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -3662,3 +3682,52 @@ class SimpleDelegatingCatalog extends
DelegatingCatalogExtension {
super.createTable(ident, columns, partitions, newProps)
}
}
+
+
+class V2CatalogSupportBuiltinDataSource extends DelegatingCatalogExtension {
+ override def name: String = "testcat3"
+
+ override def createTable(
+ ident: Identifier,
+ columns: Array[ColumnV2],
+ partitions: Array[Transform],
+ properties: util.Map[String, String]): Table = {
+ val newProps = new util.HashMap[String, String]
+ newProps.putAll(properties)
+ newProps.put(TableCatalog.PROP_LOCATION, "/tmp/test_path")
+ newProps.put(TableCatalog.PROP_EXTERNAL, "true")
+ super.createTable(ident, columns, partitions, newProps)
+ }
+
+ val delegateCatalog = {
+ val catalog = new InMemoryCatalog()
+ catalog.initialize(name, CaseInsensitiveStringMap.empty())
+ super.setDelegateCatalog(catalog)
+ catalog
+ }
+
+ override def loadTable(ident: Identifier): Table = {
+ val superTable = super.loadTable(ident)
+ val tableIdent = {
+ TableIdentifier(ident.name(), Some(ident.namespace().head), Some(name))
+ }
+ val uri =
CatalogUtils.stringToURI(superTable.properties().get(TableCatalog.PROP_LOCATION))
+ val sparkTable = CatalogTable(
+ tableIdent,
+ tableType = CatalogTableType.EXTERNAL,
+ storage = CatalogStorageFormat.empty.copy(
+ locationUri = Some(uri),
+ properties = superTable.properties().asScala.toMap
+ ),
+ schema = superTable.schema(),
+ provider = Some(superTable.properties().get(TableCatalog.PROP_PROVIDER)),
+ tracksPartitionsInCatalog = false
+ )
+ // scalastyle:off classforname
+ Class.forName("org.apache.spark.sql.connector.catalog.V1Table")
Review Comment:
ah thanks. Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
