LuciferYang commented on code in PR #47741:
URL: https://github.com/apache/spark/pull/47741#discussion_r1716349304
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -1518,6 +1518,166 @@ case class ArrayContains(left: Expression, right:
Expression)
copy(left = newLeft, right = newRight)
}
+/**
+ * Searches the specified array for the specified object using the binary
search algorithm.
+ * This expression is dedicated only for PySpark and Spark-ML.
+ */
+// scalastyle:off line.size.limit
+@ExpressionDescription(
Review Comment:
Is `@ExpressionDescription` really necessary for Internal Expressions? Since
they do not exist in `sql-expression-schema.md`, it seems there's no necessity
for it.
Moreover, the currently registered Internal Expressions are not consistent
in this regard. Most of them do not have the `@ExpressionDescription`
annotation, but a few are annotated, such as `TimestampAdd` and
`TimestampDiff`. Should we unify the format?
Additionally, should Internal Expressions be placed under a separate package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
