dongjoon-hyun commented on code in PR #47692: URL: https://github.com/apache/spark/pull/47692#discussion_r1717462339
########## docs/running-on-kubernetes.md: ########## @@ -433,8 +433,6 @@ the cluster. When there exists a log collection system, you can expose it at Spark Driver `Executors` tab UI. For example, ``` -spark.executorEnv.SPARK_EXECUTOR_ATTRIBUTE_APP_ID='$(SPARK_APPLICATION_ID)' -spark.executorEnv.SPARK_EXECUTOR_ATTRIBUTE_EXECUTOR_ID='$(SPARK_EXECUTOR_ID)' Review Comment: It's irrelevant to this PR because this PR specifically targets `Add SPARK_EXECUTOR_ATTRIBUTE_(APP|EXECUTOR)_ID if CUSTOM_EXECUTOR_LOG_URL is defined`. However, of course, you can make a documentation contribution if you want, @EnricoMi . We will review it separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
