uros-db commented on code in PR #47771:
URL: https://github.com/apache/spark/pull/47771#discussion_r1718408201
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java:
##########
@@ -1267,6 +1268,119 @@ public static UTF8String[] icuSplitSQL(final UTF8String
string, final UTF8String
return strings.toArray(new UTF8String[0]);
}
+ /**
+ * Title casing a string according to a new behaviour.
+ * Iterates over the string and title cases the first character in each
word, and lowercases
+ * every other character.
+ * Handles lowercasing greek sigma(Σ) separately, taking into account if
Review Comment:
```suggestion
* Handles lowercasing greek sigma (Σ) separately, taking into account if
```
we should try to use proper grammar in the comments
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationAwareUTF8String.java:
##########
@@ -1267,6 +1268,119 @@ public static UTF8String[] icuSplitSQL(final UTF8String
string, final UTF8String
return strings.toArray(new UTF8String[0]);
}
+ /**
+ * Title casing a string according to a new behaviour.
+ * Iterates over the string and title cases the first character in each
word, and lowercases
+ * every other character.
+ * Handles lowercasing greek sigma(Σ) separately, taking into account if
Review Comment:
(to avoid duplicate comments on the PR - this goes for all instances below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
