ilicmarkodb commented on code in PR #47521:
URL: https://github.com/apache/spark/pull/47521#discussion_r1718562002


##########
sql/core/src/test/resources/sql-tests/results/mode.sql.out:
##########
@@ -182,15 +182,9 @@ struct<mode(col):map<int,string>>
 -- !query
 SELECT mode(col, true) FROM VALUES (map(1, 'a')) AS tab(col)
 -- !query schema
-struct<>
+struct<mode() WITHIN GROUP (ORDER BY col DESC):map<int,string>>

Review Comment:
   I think that when a query throws an exception, the schema in the golden file 
appears empty. This seems to be the case for all queries in this golden file. 
However, I don't believe this necessarily means that the schema is actually 
empty.
   
   Also, when I run the Spark shell on the master code, I get the following 
output:
   scala> sql("SELECT mode(col, true) FROM VALUES (map(1, 'a')) AS tab(col)")
   val res0: org.apache.spark.sql.DataFrame = [mode() WITHIN GROUP (ORDER BY 
col DESC): map<int,string>]
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to