anishshri-db commented on code in PR #47778:
URL: https://github.com/apache/spark/pull/47778#discussion_r1719155745
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -248,13 +248,13 @@ private[sql] class RocksDBStateStoreProvider
// Used for metrics reporting around internal/external column families
def internalColFamilyCnt(): Long = {
- colFamilyNameToIdMap.keys.asScala.toSeq
- .filter(ColumnFamilyUtils.checkInternalColumnFamilies(_)).size
+ rocksDB.getColFamilyNameToIdMap.keys.
Review Comment:
rather just define the function within the store. something like
```
rocksDB.getColFamilyCount(bool internal)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
