panbingkun commented on code in PR #47741: URL: https://github.com/apache/spark/pull/47741#discussion_r1719172665
########## sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ArrayExpressionUtils.java: ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.catalyst.expressions; + +import java.io.Serializable; +import java.util.Arrays; +import java.util.Comparator; + +import org.apache.spark.sql.catalyst.util.ArrayData; +import org.apache.spark.sql.catalyst.util.SQLOrderingUtil; +import org.apache.spark.sql.types.ByteType$; +import org.apache.spark.sql.types.BooleanType$; +import org.apache.spark.sql.types.DataType; +import org.apache.spark.sql.types.DoubleType$; +import org.apache.spark.sql.types.FloatType$; +import org.apache.spark.sql.types.IntegerType$; +import org.apache.spark.sql.types.LongType$; +import org.apache.spark.sql.types.ShortType$; + +public class ArrayExpressionUtils { + + private static final Comparator<Object> booleanComp = (o1, o2) -> { + if (o1 == null && o2 == null) { + return 0; + } else if (o1 == null) { + return -1; + } else if (o2 == null) { + return 1; + } + boolean c1 = (Boolean) o1, c2 = (Boolean) o2; + return c1 == c2 ? 0 : (c1 ? 1 : -1); + }; + + private static final Comparator<Object> byteComp = (o1, o2) -> { + if (o1 == null && o2 == null) { + return 0; + } else if (o1 == null) { + return -1; + } else if (o2 == null) { + return 1; + } + byte c1 = (Byte) o1, c2 = (Byte) o2; + return Byte.compare(c1, c2); + }; + + private static final Comparator<Object> shortComp = (o1, o2) -> { + if (o1 == null && o2 == null) { + return 0; + } else if (o1 == null) { + return -1; + } else if (o2 == null) { + return 1; + } + short c1 = (Short) o1, c2 = (Short) o2; + return Short.compare(c1, c2); + }; + + private static final Comparator<Object> integerComp = (o1, o2) -> { + if (o1 == null && o2 == null) { + return 0; + } else if (o1 == null) { + return -1; + } else if (o2 == null) { + return 1; + } + int c1 = (Integer) o1, c2 = (Integer) o2; + return Integer.compare(c1, c2); + }; + + private static final Comparator<Object> longComp = (o1, o2) -> { + if (o1 == null && o2 == null) { + return 0; + } else if (o1 == null) { + return -1; + } else if (o2 == null) { + return 1; + } + long c1 = (Long) o1, c2 = (Long) o2; + return Long.compare(c1, c2); + }; + + private static final Comparator<Object> floatComp = (o1, o2) -> { + if (o1 == null && o2 == null) { + return 0; + } else if (o1 == null) { + return -1; + } else if (o2 == null) { + return 1; + } + float c1 = (Float) o1, c2 = (Float) o2; + return SQLOrderingUtil.compareFloats(c1, c2); + }; + + private static final Comparator<Object> doubleComp = (o1, o2) -> { + if (o1 == null && o2 == null) { + return 0; + } else if (o1 == null) { + return -1; + } else if (o2 == null) { + return 1; + } + double c1 = (Double) o1, c2 = (Double) o2; + return SQLOrderingUtil.compareDoubles(c1, c2); + }; + + public static int binarySearchNullSafe(ArrayData data, Boolean value) { Review Comment: Why isn't there a function similar to `public static int binarySearch(ArrayData data, boolean value)`? Because the library `Arrays` does not have such a signature function that can be used: <img width="557" alt="image" src="https://github.com/user-attachments/assets/72ad5ccc-e48c-43b6-b8f7-6f0a96cded81";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
