Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/6547#discussion_r31478931
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -29,6 +27,8 @@ import scala.concurrent.{Await, Promise}
import scala.sys.process.{Process, ProcessLogger}
import scala.util.{Random, Try}
+import com.google.common.base.Charsets
--- End diff --
I mean if importing `com.google.common.base.Charsets.UTF_8` here, you can
use `UTF_8` directly in the codes. And when we decide to switch to
`java.nio.charset.StandardCharsets.UTF_8`, we only need to update the import.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
