anishshri-db commented on code in PR #47778:
URL: https://github.com/apache/spark/pull/47778#discussion_r1721173178
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -166,6 +170,79 @@ class RocksDB(
@GuardedBy("acquireLock")
@volatile private var acquiredThreadInfo: AcquiredThreadInfo = _
+ // This is accessed and updated only between load and acquire
+ // which means it is implicitly guarded by acquireLock
+ private val colFamilyNameToIdMap = new ConcurrentHashMap[String, Short]()
+
+ private val defaultColumnFamilyIdMapping =
+ Map(StateStore.DEFAULT_COL_FAMILY_NAME ->
StateStore.DEFAULT_COL_FAMILY_ID).asJava
+
+ private val maxColumnFamilyId: AtomicInteger = new AtomicInteger(0)
Review Comment:
Lets specify `@GuardedBy("acquireLock")` for all of these ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
