pan3793 commented on code in PR #47500:
URL: https://github.com/apache/spark/pull/47500#discussion_r1721186702


##########
common/utils/src/main/scala/org/apache/spark/internal/Logging.scala:
##########
@@ -391,7 +392,8 @@ trait Logging {
 private[spark] object Logging {
   @volatile private var initialized = false
   @volatile private var defaultRootLevel: Level = null
-  @volatile private var defaultSparkLog4jConfig = false
+  @volatile private var shouldUseDefaultSparkLog4jConfig = false
+  @volatile private var defaultSparkLog4jConfigApplied = false

Review Comment:
   Sorry for the late reply.
   
   Not exactly. I found
   ```
   Logging.initializeLogging()
   Logging.uninitialize()
   Logging.initializeLogging() # this **may** not work properly again
   ```
   
   To fix the semantic, it introduces a flag to memorize the action of the 
first call `initializeLogging`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to