dongjoon-hyun commented on code in PR #71:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/71#discussion_r1722353511
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/utils/ProbeUtil.java:
##########
@@ -30,11 +30,20 @@
import io.javaoperatorsdk.operator.RuntimeInfo;
import lombok.extern.slf4j.Slf4j;
+/** A utility class to provide common functionalities for probe services. */
@Slf4j
public final class ProbeUtil {
private ProbeUtil() {}
+ /**
+ * Send an HTTP response message with the given response header HTTP status
code and message.
+ *
+ * @param httpExchange The handler for this HTTP response.
+ * @param code A response header HTTP status code defined in
java.net.HttpURLConnection.HTTP_*
+ * @param message A message to send as a body
+ * @throws IOException Failed to send a response.
+ */
Review Comment:
I also documented this public method to be clear about the `code` parameter
usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
