HeartSaVioR commented on code in PR #47794:
URL: https://github.com/apache/spark/pull/47794#discussion_r1722620403
##########
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala:
##########
@@ -1286,12 +1286,12 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
rebuildAppStore(store, reader, attempt.info.lastUpdated.getTime())
hybridStore = store
} catch {
- case _: IOException if !retried =>
+ case ioe: IOException if !retried =>
// compaction may touch the file(s) which app rebuild wants to read
// compaction wouldn't run in short interval, so try again...
logWarning(log"Exception occurred while rebuilding log path " +
log"${MDC(PATH, attempt.logPath)} - " +
- log"trying again...")
+ log"trying again...", ioe)
Review Comment:
I'm OK to change this to INFO as there will be fallback anyway. @robreeves
Would you mind making a change, or would you mind keeping the level for
specific reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
