viirya commented on code in PR #75:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/75#discussion_r1722800690
##########
spark-operator-api/src/main/java/org/apache/spark/k8s/operator/Constants.java:
##########
@@ -80,4 +84,12 @@ public class Constants {
"The Spark application is running with less than minimal number of
requested executors.";
public static final String EXECUTOR_LAUNCH_TIMEOUT_MESSAGE =
"The Spark application failed to get enough executors in the given time
threshold.";
+
+ // Spark Cluster Messages
+ public static final String CLUSTER_SCHEDULE_FAILURE_MESSAGE =
+ "Failed to request Spark cluster from scheduler backend.";
+ public static final String CLUSTER_SUBMITTED_STATE_MESSAGE =
+ "Spark cluster has been created on Kubernetes Cluster.";
Review Comment:
"Submitted" doesn't mean the cluster is created, right? Should it be
"submitted?
##########
spark-operator-api/src/main/java/org/apache/spark/k8s/operator/status/ClusterStateSummary.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.spark.k8s.operator.status;
+
+public enum ClusterStateSummary implements BaseStateSummary {
+ /** Spark cluster is submitted but yet scheduled */
+ Submitted,
+
+ SchedulingFailure,
Review Comment:
This misses a doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
