dongjoon-hyun commented on code in PR #77:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/77#discussion_r1724167678
##########
.github/workflows/build_and_test.yml:
##########
@@ -72,14 +81,18 @@ jobs:
java-version: 21
distribution: 'adopt'
cache: 'gradle'
- - name: start minikube
+ - name: Set Up Minikube
+ uses: medyagh/[email protected]
+ with:
+ cache: true
+ kubernetes-version: ${{ matrix.kube-version }}
+ cpu: 4
Review Comment:
It seems that Apache Spark community decided to use `2` based on the
historic stability. This new value, `4`, looks larger than before. Is this okay?
https://github.com/apache/spark/blob/33059396bd2d529d499498106f51a42328b457ca/.github/workflows/build_and_test.yml#L1121-L1122
```
# Github Action limit cpu:2, memory: 6947MB, limit to 2U6G for
better resource statistic
minikube start --cpus 2 --memory 6144
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
