MaxGekk commented on code in PR #47817:
URL: https://github.com/apache/spark/pull/47817#discussion_r1724517140


##########
sql/core/src/test/scala/org/apache/spark/sql/MiscFunctionsSuite.scala:
##########
@@ -285,6 +285,48 @@ class MiscFunctionsSuite extends QueryTest with 
SharedSparkSession {
     assert(df.selectExpr("random(1)").collect() != null)
     assert(df.select(random(lit(1))).collect() != null)
   }
+
+  test("SPARK-49306 nullifzero and zeroifnull functions") {

Review Comment:
   This test suite is for misc functions mostly. Could you move expression 
tests to `ConditionalExpressionSuite` and end-to-end tests to 
`conditional-functions.sql`, please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to