dongjoon-hyun commented on code in PR #47832:
URL: https://github.com/apache/spark/pull/47832#discussion_r1725716517
##########
.github/workflows/build_and_test.yml:
##########
@@ -1112,14 +1112,12 @@ jobs:
with:
distribution: zulu
java-version: ${{ inputs.java }}
- - name: start minikube
- run: |
- # See more in "Installation" https://minikube.sigs.k8s.io/docs/start/
- curl -LO
https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64
- sudo install minikube-linux-amd64 /usr/local/bin/minikube
- rm minikube-linux-amd64
+ - name: Start Minikube
+ uses: medyagh/[email protected]
Review Comment:
To @bjornjorgensen , we use `pinned` GitHub Action always.
```
$ git grep setup .github/workflows/build_and_test.yml
.github/workflows/build_and_test.yml: uses: actions/setup-java@v4
.github/workflows/build_and_test.yml: uses: actions/setup-python@v5
.github/workflows/build_and_test.yml: uses:
docker/setup-qemu-action@v3
.github/workflows/build_and_test.yml: uses:
docker/setup-buildx-action@v3
.github/workflows/build_and_test.yml: uses: actions/setup-java@v4
.github/workflows/build_and_test.yml: uses: actions/setup-java@v4
.github/workflows/build_and_test.yml: # The followings are also used
by `r-lib/actions/setup-r` to avoid
.github/workflows/build_and_test.yml: uses: bufbuild/buf-setup-action@v1
.github/workflows/build_and_test.yml: uses: actions/setup-python@v5
.github/workflows/build_and_test.yml: uses: actions/setup-java@v4
.github/workflows/build_and_test.yml: uses: actions/setup-java@v4
.github/workflows/build_and_test.yml: uses: actions/setup-java@v4
.github/workflows/build_and_test.yml: uses: actions/setup-java@v4
.github/workflows/build_and_test.yml: uses: actions/setup-java@v4
.github/workflows/build_and_test.yml: uses: actions/setup-node@v4
```
In addition, the GitHub Action version is irrelevant to the Minikube
version. According to the log, it downloads the latest Minikube 1.33.1 like the
picture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
