hvanhovell commented on code in PR #47839:
URL: https://github.com/apache/spark/pull/47839#discussion_r1726187085
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala:
##########
@@ -300,17 +297,35 @@ object CheckConnectJvmClientCompatibility {
ProblemFilters.exclude[DirectMissingMethodProblem](
"org.apache.spark.sql.UDFRegistration.register"),
- // Typed Column
-
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.TypedColumn.*"),
- ProblemFilters.exclude[IncompatibleResultTypeProblem](
- "org.apache.spark.sql.TypedColumn.expr"),
-
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.TypedColumn$"),
-
// ColumnNode conversions
ProblemFilters.exclude[DirectMissingMethodProblem](
"org.apache.spark.sql.SparkSession.Converter"),
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.SparkSession$Converter$"),
-
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.SparkSession$RichColumn"),
+
+ // Missing expressions.
+ ProblemFilters.exclude[MissingClassProblem](
+ "org.apache.spark.sql.expressions.ReduceAggregator"),
+ ProblemFilters.exclude[MissingClassProblem](
+ "org.apache.spark.sql.expressions.ReduceAggregator$"),
+
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.expressions.javalang.*"),
+
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.sql.expressions.scalalang.*"),
+
+ // UDFRegistration
Review Comment:
This weird thing is that the MiMa check misses the one missing method we do
care about :/...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
