Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6558#discussion_r31485428
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetConverter.scala ---
@@ -244,7 +244,7 @@ private[parquet] abstract class CatalystConverter
extends GroupConverter {
* Read a decimal value from a Parquet Binary into "dest". Only supports
decimals that fit in
* a long (i.e. precision <= 18)
*/
- protected[parquet] def readDecimal(dest: Decimal, value: Binary, ctype:
DecimalType): Unit = {
+ protected[parquet] def readDecimal(dest: Decimal, value: Binary, ctype:
DecimalType): Decimal = {
--- End diff --
oh, I just realized that when we reuse the Decimal value, we do not really
need to use the returned value. But, we have another place that needs the
returned value. Can we add a comment at here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
