dongjoon-hyun commented on code in PR #89:
URL: 
https://github.com/apache/spark-kubernetes-operator/pull/89#discussion_r1726357645


##########
spark-submission-worker/src/main/java/org/apache/spark/k8s/operator/SparkClusterResourceSpec.java:
##########
@@ -129,6 +131,7 @@ private static StatefulSet buildMasterStatefulSet(
         .addToLabels(LABEL_SPARK_ROLE_NAME, LABEL_SPARK_ROLE_MASTER_VALUE)
         .endMetadata()
         .withNewSpec()
+        .withSchedulerName(scheduler)

Review Comment:
   Although we can set `schedulerName` like this, we cannot add a test case 
because `fabric8` doesn't have `getSchedulerName` unlike `PodSpec`.
   - 
https://github.com/fabric8io/kubernetes-client/blob/main/kubernetes-model-generator/kubernetes-model-apps/src/generated/java/io/fabric8/kubernetes/api/model/apps/StatefulSetSpec.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to