uros-db commented on code in PR #47825: URL: https://github.com/apache/spark/pull/47825#discussion_r1726424328
########## sql/core/src/test/resources/sql-tests/inputs/collations.sql: ########## @@ -90,3 +90,14 @@ select 'a' collate en_ci_ai = 'Å'; select 'Kypper' collate sv < 'Köpfe'; select 'Kypper' collate de > 'Köpfe'; select 'I' collate tr_ci = 'ı'; + +-- create table for str_to_map +create table t1 (text string collate utf8_binary, pairDelim string collate utf8_lcase, keyValueDelim string collate utf8_binary) using parquet; Review Comment: ```suggestion create table t4 (text string collate utf8_binary, pairDelim string collate utf8_lcase, keyValueDelim string collate utf8_binary) using parquet; ``` let's just use another table name here, so that we don't confuse it with the three tables above in the future (I know that the naming is not currently consistent, but we do have an ongoing effort to revamp this golden file - https://issues.apache.org/jira/browse/SPARK-48779) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
