viktorluc-db commented on code in PR #47847:
URL: https://github.com/apache/spark/pull/47847#discussion_r1727363496
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##########
@@ -90,6 +90,15 @@ object CollationTypeCasts extends TypeCoercionRule {
val newValues = collateToSingleType(mapCreate.values)
mapCreate.withNewChildren(newKeys.zip(newValues).flatMap(pair =>
Seq(pair._1, pair._2)))
+ case levenshtein: Levenshtein =>
+ val Seq(left, right) = Seq(levenshtein.children.head,
levenshtein.children(1))
+ val Seq(newLeft, newRight) = collateToSingleType(Seq(left, right))
+ if (levenshtein.children.size == 2) {
+ levenshtein.withNewChildren(Seq(newLeft, newRight))
+ } else {
+ levenshtein.withNewChildren(Seq(newLeft, newRight,
levenshtein.children(2)))
+ }
Review Comment:
I think that if Levenshtein is going to support at least another collation
in the future(instead of being pass-through), then we would need to enforce
both of the strings to be of the same collation type. I think that the chance
for more than one collation support for Levenshtein is non-zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
