cxzl25 commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1728682909
##########
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java:
##########
@@ -416,8 +419,8 @@ public void insertRecord(Object recordBase, long
recordOffset, int length, int p
// for tests
assert(inMemSorter != null);
if (inMemSorter.numRecords() >= numElementsForSpillThreshold) {
- logger.info("Spilling data because number of spilledRecords crossed the
threshold " +
- numElementsForSpillThreshold);
+ logger.info("Spilling data because number of spilledRecords crossed the
threshold {}" +
Review Comment:
When re-implementing SPARK-27734, I found that there was something wrong
with the logs here.
` {}" + MDC.of ` -> `{}", MDC.of`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
