xupefei commented on code in PR #47815:
URL: https://github.com/apache/spark/pull/47815#discussion_r1730986833
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -122,6 +124,12 @@ class SparkSession private(
.getOrElse(SQLConf.getFallbackConf)
})
+ /**
+ * A map to hold the mapping from user-defined tags to the real tags
attached to Jobs.
+ * Real tag have the current session ID attached: `"tag1" ->
s"spark-$sessionUUID-tag1"`.
+ */
+ private val userDefinedToRealTagsMap: ConcurrentHashMap[String, String] =
new ConcurrentHashMap()
Review Comment:
Good point. I'll change the code.
Btw, how should we handle session IDs? Should calling `interruptAll` from
parent sessions terminate jobs from child sessions?
##########
sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -122,6 +124,12 @@ class SparkSession private(
.getOrElse(SQLConf.getFallbackConf)
})
+ /**
+ * A map to hold the mapping from user-defined tags to the real tags
attached to Jobs.
+ * Real tag have the current session ID attached: `"tag1" ->
s"spark-$sessionUUID-tag1"`.
+ */
+ private val userDefinedToRealTagsMap: ConcurrentHashMap[String, String] =
new ConcurrentHashMap()
Review Comment:
Good point. I'll change the code.
Btw, how should we handle session IDs? Should calling `interruptAll` from
parent sessions terminate jobs from child sessions (I think we should)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
