mkaravel commented on code in PR #47771: URL: https://github.com/apache/spark/pull/47771#discussion_r1731560185
########## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/SpecialCodePointConstants.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.util; + +public class SpecialCodePointConstants { + + public static final int COMBINING_DOT = 0x0307; + public static final int ASCII_SMALL_I = 0x0069; + /** + * `COMBINED_ASCII_SMALL_I_COMBINING_DOT` is an internal representation of the combined + * lowercase code point for ASCII lowercase letter i with an additional combining dot character + * (U+0307). This integer value is not a valid code point itself, but rather an artificial code + * point marker used to represent the two lowercase characters that are the result of converting + * the uppercase Turkish dotted letter I with a combining dot character (U+0130) to lowercase. Review Comment: Maybe also explain why we introduce it and how we use it? Specifically for this one, given that it is not a real codepoint, we may want to keep it local inside the class we use it. this way there is no ambiguity regarding the scope of usage, and we avoid exposing something that is an implementation detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
