tianhanhu-db commented on code in PR #47793:
URL: https://github.com/apache/spark/pull/47793#discussion_r1731969762
##########
core/src/main/scala/org/apache/spark/scheduler/TaskSetExcludeList.scala:
##########
@@ -163,3 +167,18 @@ private[scheduler] class TaskSetExcludelist(
}
}
}
+
+private[scheduler] object TaskSetExcludelist {
+
+ /**
+ * Returns true if the excludeOnFailure is enabled on the task/stage level,
+ * based on checking the configuration in the following order:
+ * 1. Is taskset level exclusion specifically enabled or disabled?
+ * 2. Is overall exclusion feature enabled or disabled?
+ * 3. Default is off
+ */
+ def isExcludeOnFailureEnabled(conf: SparkConf): Boolean = {
Review Comment:
My thought is to have the taskset/application level configs as the new
standard knobs, and treat `spark.excludeOnFailure.enabled` as a legacy fallback
for backward compatibilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
