panbingkun commented on PR #46880: URL: https://github.com/apache/spark/pull/46880#issuecomment-2311672349
> Do we have a strong reason to make this breaking change? How bad is it when calling `sentences` with two parameters? Mainly because the inconsistent use of function `sentences` in the following scenarios may cause confusion for end-users <img width="1051" alt="image" src="https://github.com/apache/spark/assets/15246973/033c731d-5a2f-455f-8517-ed95bd6c1f6e";> One allows 2 parameters, while the other does not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
