MaxGekk commented on code in PR #47886:
URL: https://github.com/apache/spark/pull/47886#discussion_r1732479810
##########
sql/core/src/test/scala/org/apache/spark/sql/ParametersSuite.scala:
##########
@@ -682,6 +682,24 @@ class ParametersSuite extends QueryTest with
SharedSparkSession with PlanTest {
}
}
+ test("SPARK-49017: bind named parameters with IDENTIFIER clause in create
table as") {
+ withTable("testtab", "testtab1") {
+ // Create table
Review Comment:
It is useless comment, I think. Let's remove it.
##########
sql/core/src/test/scala/org/apache/spark/sql/ParametersSuite.scala:
##########
@@ -682,6 +682,24 @@ class ParametersSuite extends QueryTest with
SharedSparkSession with PlanTest {
}
}
+ test("SPARK-49017: bind named parameters with IDENTIFIER clause in create
table as") {
+ withTable("testtab", "testtab1") {
+ // Create table
+ spark.sql("create table testtab (id int, name string)")
+
+ // Insert into table using single param
+ sql("insert into testtab values(1, 'test1')")
+
+ // cache table with parameters in query
Review Comment:
Sorry, I didn't get where is the cache here.
##########
sql/core/src/test/scala/org/apache/spark/sql/ParametersSuite.scala:
##########
@@ -682,6 +682,24 @@ class ParametersSuite extends QueryTest with
SharedSparkSession with PlanTest {
}
}
+ test("SPARK-49017: bind named parameters with IDENTIFIER clause in create
table as") {
+ withTable("testtab", "testtab1") {
+ // Create table
+ spark.sql("create table testtab (id int, name string)")
+
+ // Insert into table using single param
Review Comment:
hmm, where is the single param?
##########
sql/core/src/test/scala/org/apache/spark/sql/ParametersSuite.scala:
##########
@@ -682,6 +682,24 @@ class ParametersSuite extends QueryTest with
SharedSparkSession with PlanTest {
}
}
+ test("SPARK-49017: bind named parameters with IDENTIFIER clause in create
table as") {
+ withTable("testtab", "testtab1") {
+ // Create table
+ spark.sql("create table testtab (id int, name string)")
Review Comment:
```suggestion
sql("create table testtab (id int, name string)")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
