jshmchenxi commented on code in PR #47945:
URL: https://github.com/apache/spark/pull/47945#discussion_r1740696519
##########
core/src/main/scala/org/apache/spark/BarrierCoordinator.scala:
##########
@@ -51,7 +52,8 @@ private[spark] class BarrierCoordinator(
// TODO SPARK-25030 Create a Timer() in the mainClass submitted to
SparkSubmit makes it unable to
// fetch result, we shall fix the issue.
- private lazy val timer = new Timer("BarrierCoordinator barrier epoch
increment timer")
+ private lazy val timer = ThreadUtils.newSingleThreadScheduledExecutor(
Review Comment:
That's right, we need to change to using
`newDaemonThreadPoolScheduledExecutor` to solve this issue. The master branch
also has this problem. I'll submit another PR with a reproducible test. Thanks
for your suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
