Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6555#discussion_r31491751
--- Diff: external/flume-sink/pom.xml ---
@@ -42,22 +42,47 @@
<dependency>
<groupId>org.apache.flume</groupId>
<artifactId>flume-ng-sdk</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
<groupId>org.apache.flume</groupId>
<artifactId>flume-ng-core</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.thrift</groupId>
+ <artifactId>libthrift</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
</dependency>
+ <!--
+ Dependencies explicitly added in test as they have been excluded from
+ Flume dependency (to avoid runtime problems when running with
+ Spark) but unit tests need it.
+ -->
<dependency>
- <!--
- Netty explicitly added in test as it has been excluded from
- Flume dependency (to avoid runtime problems when running with
- Spark) but unit tests need it. Version of Netty on which
- Flume 1.4.0 depends on is "3.4.0.Final" .
- -->
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
--- End diff --
There's no wrong version of Guava.
I added this because I removed Guava from compile-scope dependencies, to
avoid having people use it in this module. Not because of a conflict.
If instead you'd rather keep it, but at the same version as flume (whatever
that is), it could be done also. I kinda prefer avoiding it, though.
As I mention in the PR description, the minimal fix doesn't remove Guava at
all, just removes the code to relocate it. I just thought it would be better to
avoid another potential dependency mess here since it's not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
