cxzl25 commented on code in PR #47908:
URL: https://github.com/apache/spark/pull/47908#discussion_r1741405657
##########
core/src/main/scala/org/apache/spark/ui/UIUtils.scala:
##########
@@ -446,16 +446,24 @@ private[spark] object UIUtils extends Logging {
val startRatio = if (total == 0) 0.0 else (boundedStarted.toDouble /
total) * 100
val startWidth = "width: %s%%".format(startRatio)
+ val killTaskReasonText = reasonToNumKilled.toSeq.sortBy(-_._2).map {
+ case (reason, count) => s" ($count killed: $reason)"
+ }.mkString
+ val progressTitle = s"$completed/$total" + {
+ if (started > 0) s" ($started running)" else ""
+ } + {
+ if (failed > 0) s" ($failed failed)" else ""
+ } + {
+ if (skipped > 0) s" ($skipped skipped)" else ""
+ } + killTaskReasonText
+
<div class="progress">
- <span style="text-align:center; position:absolute; width:100%;">
+ <span style="text-align:center; position:absolute; width:100%;"
title={progressTitle}>
{completed}/{total}
{ if (failed == 0 && skipped == 0 && started > 0) s"($started
running)" }
{ if (failed > 0) s"($failed failed)" }
{ if (skipped > 0) s"($skipped skipped)" }
- { reasonToNumKilled.toSeq.sortBy(-_._2).map {
- case (reason, count) => s"($count killed: $reason)"
- }
- }
+ { killTaskReasonText }
Review Comment:
The logic of running tasks displayed by the two is different.
```
if (started > 0) s" ($started running)" else ""
```
---
```
{ if (failed == 0 && skipped == 0 && started > 0) s"($started running)" }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
