Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6524#discussion_r31492013
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -644,14 +644,24 @@ class Analyzer(
}
/**
- * From a Seq of [[NamedExpression]]s, extract window expressions and
- * other regular expressions.
+ * From a Seq of [[NamedExpression]]s, extract expressions containing
window expressions and
+ * other regular expressions that do not contain any window
expression. For example, for
+ * `col1, Sum(col2 + col3) OVER (PARTITION BY col4 ORDER BY col5)`, we
will extract
+ * `col1`, `col2 + col3`, `col4`, and `col5` out and replace them
appearances in
--- End diff --
Nit: them -> their.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
