hvanhovell commented on code in PR #47963:
URL: https://github.com/apache/spark/pull/47963#discussion_r1742406686
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/MergeIntoDataFrameSuite.scala:
##########
@@ -959,7 +960,9 @@ class MergeIntoDataFrameSuite extends
RowLevelOperationSuiteBase {
.insertAll()
.whenNotMatchedBySource(col("col") === 1)
.delete()
+ .asInstanceOf[MergeIntoWriterImpl[Row]]
val writer2 = writer1.withSchemaEvolution()
Review Comment:
It is weird to me that everything else in the builder is mutable besides the
schema evolution flag. It should be either fully immutable, or not at all... I
lean towards mutability because all of the other builders are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
