dongjoon-hyun commented on code in PR #46781:
URL: https://github.com/apache/spark/pull/46781#discussion_r1742628630
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/MSSQLConnectionProvider.scala:
##########
@@ -38,18 +38,16 @@ private[sql] class MSSQLConnectionProvider extends
SecureConnectionProvider {
val parseURL = try {
// The default parser method signature is the following:
// private Properties parseAndMergeProperties(String Url, Properties
suppliedProperties)
- val m = driver.getClass.getDeclaredMethod(parserMethod, classOf[String],
classOf[Properties])
- m.setAccessible(true)
Review Comment:
This looks irrelevant from the PR title. Why do we remove `setAccessible`
here?
`parseAndMergeProperties` is `private`, isn't it? If this is not `private`,
we need to change the comment at line 40 together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
