davintjong-db commented on code in PR #47944:
URL: https://github.com/apache/spark/pull/47944#discussion_r1742817997


##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/ConnectProgressExecutionListener.scala:
##########
@@ -144,7 +144,9 @@ private[connect] class ConnectProgressExecutionListener 
extends SparkListener wi
         tracker.stages.get(taskEnd.stageId).foreach { stage =>
           stage.update { i =>
             i.completedTasks += 1

Review Comment:
   Not 100% on this, do we not want to progress if the metrics were `null`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to