mridulm commented on code in PR #47352:
URL: https://github.com/apache/spark/pull/47352#discussion_r1742959980
##########
core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala:
##########
@@ -69,13 +69,15 @@ import org.apache.spark.util.Utils
* [options] represent the specific property of this source or sink.
*/
private[spark] class MetricsSystem private (
- val instance: String, conf: SparkConf) extends Logging {
+ val instance: String,
+ conf: SparkConf,
+ registry: MetricRegistry)
+ extends Logging {
private[this] val metricsConfig = new MetricsConfig(conf)
private val sinks = new mutable.ArrayBuffer[Sink]
- private val sources = new mutable.ArrayBuffer[Source]
- private val registry = new MetricRegistry()
+ private val sourcesWithListeners = new mutable.HashMap[Source,
MetricRegistryListener]
Review Comment:
```suggestion
private val sourcesWithListeners = new mutable.ArrayBuffer[(Source,
MetricRegistryListener)]
```
Let us preserve the current semantics and not introduce assumption that
Source has consistent `equals`/`hashCode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
