xinrong-meng commented on PR #47884: URL: https://github.com/apache/spark/pull/47884#issuecomment-2328066960
I noticed that a new Analyzer is created in the test suite ProtoToParsedPlanTestSuite, see [here](https://github.com/apache/spark/blob/master/sql/connect/server/src/test/scala/org/apache/spark/sql/connect/ProtoToParsedPlanTestSuite.scala#L160). This is why it didn’t recognize the rule added in BaseSessionStateBuilder, see [here](https://github.com/apache/spark/pull/47884/files#diff-9806431743675ca892eb73a801af2f4c43086f87ecbc0c94900c8f18660f4a50R208). I don’t see a simple fix at the moment. When I tried overriding extendedResolutionRules in the new Analyzer of the test suite, the SparkSession was null, leading to: ``` [info] java.lang.NullPointerException: Cannot invoke "org.apache.spark.sql.SparkSession.sessionState()" because "this.$outer.org$apache$spark$sql$catalyst$analysis$ResolveTranspose$$sparkSession" is null ``` I propose skipping the test suite in this PR and will file a follow-up for the fix. WDYT @HyukjinKwon @cloud-fan @zhengruifeng @hvanhovell ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
