davidm-db commented on code in PR #47973:
URL: https://github.com/apache/spark/pull/47973#discussion_r1743967140
##########
sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionNodeSuite.scala:
##########
@@ -35,6 +35,10 @@ class SqlScriptingExecutionNodeSuite extends SparkFunSuite
with SharedSparkSessi
override def reset(): Unit = ()
}
+ case class TestLeaveStatement(labelText: String) extends
LeaveStatementExec(labelText)
+
+ case class TestIterateStatement(labelText: String) extends
IterateStatementExec(labelText)
Review Comment:
because I'm dumb :) Used these in `extractStatementValue` to match on
`labelText` directly instead of matching by type only and using
`Leave/IterateStatementExec`... will change in the next commit to use regular
exec nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]