cloud-fan commented on code in PR #47995:
URL: https://github.com/apache/spark/pull/47995#discussion_r1744749196
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -684,7 +693,8 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
}
private def supportsV1Command(catalog: CatalogPlugin): Boolean = {
- isSessionCatalog(catalog) &&
- SQLConf.get.getConf(SQLConf.V2_SESSION_CATALOG_IMPLEMENTATION).isEmpty
+ (isSessionCatalog(catalog) &&
Review Comment:
I think `isSessionCatalog(catalog)` should always be checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
