ericm-db commented on code in PR #47490:
URL: https://github.com/apache/spark/pull/47490#discussion_r1745760104
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateSchemaCompatibilityChecker.scala:
##########
@@ -186,6 +186,10 @@ class StateSchemaCompatibilityChecker(
check(existingStateSchema, newSchema, ignoreValueSchema)
}
}
+ // we want to write the new schema file on each new run for state schema
v3
+ if (stateSchemaVersion == 3) {
+ createSchemaFile(newStateSchemaList, stateSchemaVersion)
Review Comment:
Hopefully the check I added is enough? I didn't want to get into the
semantics of evolution in this PR, which is why I didn't modify the `check`
method or use that result anywhere here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
