pan3793 commented on PR #47997: URL: https://github.com/apache/spark/pull/47997#issuecomment-2333080695
thanks for fixing this, a small suggestion about the folder layout. instead of ``` <module>/src/main/scala <module>/volcano/src/main/scala ``` how about ``` <module>/src/main/scala <module>/src/main/volcano ``` the former makes `volcano` like a sub-module but it is not, the latter is also commonly used in the following situations ``` <module>/src/main/antlr <module>/src/main/thrift <module>/src/main/scala <module>/src/main/scala-2.12 <module>/src/main/scala-2.13 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
