mridulm commented on code in PR #47815:
URL: https://github.com/apache/spark/pull/47815#discussion_r1747358212
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2684,6 +2685,25 @@ class SparkContext(config: SparkConf) extends Logging {
dagScheduler.cancelJobGroup(groupId, cancelFutureJobs = true, None)
}
+ /**
+ * Cancel active jobs that have the specified tag. See
`org.apache.spark.SparkContext.addJobTag`.
+ *
+ * @param tag The tag to be cancelled. Cannot contain ',' (comma) character.
+ * @param reason reason for cancellation.
+ * @return A future with [[ActiveJob]]s, allowing extraction of information
such as Job ID and
+ * tags.
+ */
+ private[spark] def cancelJobsWithTagWithFuture(
Review Comment:
There is already existing support for group id - why not leverage that
instead of adding a new construct ?
I did not see the initial PR in 4.0 which added tag to dag scheduler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
