HeartSaVioR commented on code in PR #48026:
URL: https://github.com/apache/spark/pull/48026#discussion_r1749435256


##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4271,7 +4271,8 @@
   },
   "STREAM_FAILED" : {
     "message" : [
-      "Query [id = <id>, runId = <runId>] terminated with exception: <message>"
+      "Query [id = <id>, runId = <runId>, startOffset = <startOffset>, 
endOffset = <endOffset>] terminated with exception: <message>",
+      "<queryDebugString>"

Review Comment:
   This seems to be slightly messed up -
   
   
https://github.com/apache/spark/blob/master/common/utils/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryException.scala
   
   This class overrides getMessage and handles queryDebugString separately. So 
it's expected to not have queryDebugString here.
   
   What I'm confused is why we have a case where queryDebugString is passed 
over message parameters, since we have constructors which directly receive 
queryDebugString.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to