panbingkun commented on code in PR #46880: URL: https://github.com/apache/spark/pull/46880#discussion_r1749484791
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ########## @@ -3333,22 +3333,45 @@ case class FormatNumber(x: Expression, d: Expression) /** * Splits a string into arrays of sentences, where each sentence is an array of words. - * The 'lang' and 'country' arguments are optional, and if omitted, the default locale is used. + * The `lang` and `country` arguments are optional, their default values are all '', + * - When they are omitted: + * 1. If they are both omitted, the `locale(language='', country='')` is used. Review Comment: Yes, this is Local.ROOT <img width="1167" alt="image" src="https://github.com/user-attachments/assets/78d6f1d1-db0e-430b-ae7c-20f680a58934";> Let me update it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
