LuciferYang commented on code in PR #48032:
URL: https://github.com/apache/spark/pull/48032#discussion_r1750094036
##########
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java:
##########
@@ -287,10 +287,11 @@ private void addToClassPath(Set<String> cp, String
entries) {
}
/**
- * Checks if the spark-hive jar file is available in the specified directory.
+ * Checks if a JAR file with a specific prefix is available in the given
directory.
*
- * @param jarsDir the directory to search for spark-hive jar files
- * @return true if a file starting with "spark-hive_" is found, false
otherwise
+ * @param jarsDir the directory to search for JAR files
+ * @param jarNamePrefix the prefix of the JAR file name to look for
+ * @return true if a JAR file with the specified prefix is found, false
otherwise
Review Comment:
@HyukjinKwon I'm very sorry, I forgot to update the comments for this method
before merging.
##########
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java:
##########
@@ -287,10 +287,11 @@ private void addToClassPath(Set<String> cp, String
entries) {
}
/**
- * Checks if the spark-hive jar file is available in the specified directory.
+ * Checks if a JAR file with a specific prefix is available in the given
directory.
*
- * @param jarsDir the directory to search for spark-hive jar files
- * @return true if a file starting with "spark-hive_" is found, false
otherwise
+ * @param jarsDir the directory to search for JAR files
+ * @param jarNamePrefix the prefix of the JAR file name to look for
+ * @return true if a JAR file with the specified prefix is found, false
otherwise
Review Comment:
cc @HyukjinKwon
I'm very sorry, I forgot to update the comments for this method before
merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
