mikhailnik-db commented on code in PR #48055:
URL: https://github.com/apache/spark/pull/48055#discussion_r1751612040


##########
sql/core/src/test/scala/org/apache/spark/sql/ParametersSuite.scala:
##########
@@ -715,4 +715,20 @@ class ParametersSuite extends QueryTest with 
SharedSparkSession with PlanTest {
     spark.sessionState.analyzer.executeAndCheck(analyzedPlan, 
df.queryExecution.tracker)
     checkAnswer(df, Row(11))
   }
+
+  test("SPARK-49398: Cache Table with Parameter markers should throw " +

Review Comment:
   > Could you please add test were we do not use query to cache, but use only 
table name. It is important to test all paths and make sure we pass in all of 
them.
   
   Do you mean `CACHE TABLE CachedTable TABLE SomeTable` syntax? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to