gene-db commented on code in PR #48064: URL: https://github.com/apache/spark/pull/48064#discussion_r1752923065
########## common/variant/README.md: ########## @@ -362,6 +362,8 @@ The Decimal type contains a scale, but no precision. The implied precision of a | 18 <= precision <= 38 | int128 | | > 38 | Not supported | +The *Logical Type* column indicates logical equivalence of physically encoded types. For example, a user expression operating on a string value containing "hello" should behave the same, whether it is encoded with the short string optimization, or long string encoding. Similarly, user expressions operating on an *int8* value of 1 should behave the same as a decimal16 with scale 2 and unscaled value 100. Review Comment: If `int8` and other int types are `Exact Numeric` and decimals are `Exact Numeric` how do they relate when the decimal values can represent non-integers? For example, a decimal with scale 2 and unscaled value 123 is an `Exact Numeric` and an `int8` with value 1 is also a `Exact Numeric`. Those seem like different classes of values? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
