dtenedor commented on code in PR #48047:
URL: https://github.com/apache/spark/pull/48047#discussion_r1752933403
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -5677,4 +5677,29 @@ class AstBuilder extends DataTypeAstBuilder
withOrigin(ctx) {
visitSetVariableImpl(ctx.query(), ctx.multipartIdentifierList(),
ctx.assignmentList())
}
+
+ override def visitOperatorPipeStatement(ctx: OperatorPipeStatementContext):
LogicalPlan = {
+ visitOperatorPipeRightSide(ctx.operatorPipeRightSide(), plan(ctx.left))
+ }
+
+ private def visitOperatorPipeRightSide(
+ ctx: OperatorPipeRightSideContext, left: LogicalPlan): LogicalPlan = {
+ if (!SQLConf.get.getConf(SQLConf.OPERATOR_PIPE_SYNTAX_ENABLED)) {
+ operationNotAllowed("Operator pipe SQL syntax using |>", ctx)
+ }
+ Option(ctx.selectClause).map { c =>
+ withSelectQuerySpecification(
+ ctx = ctx,
+ selectClause = c,
+ lateralView = new java.util.ArrayList[LateralViewContext](),
+ whereClause = null,
+ aggregationClause = null,
+ havingClause = null,
+ windowClause = null,
+ left) match {
+ case p: Project =>
Review Comment:
Good Q, this input should always be a projection since we only pass a
context for the SELECT clause here and pass "null" for all other clauses. I
added a comment here to this effect.
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -3707,6 +3707,12 @@
],
"sqlState" : "42K03"
},
+ "PIPE_OPERATOR_SELECT_CONTAINS_AGGREGATE_FUNCTION" : {
+ "message" : [
+ "Aggregate function <expr> is not allowed when using the pipe operator
|> SELECT clause; please use the pipe operator |> AGGREGATE clause instead"
Review Comment:
Yes, this will be tracked in a separate Jira task. The intention is that `|>
SELECT` will not allow aggregate functions (ever). So this restriction on not
allowing aggregate functions in `|> SELECT` will be permanent.
Until we implement `|> AGGREGATE` later, it won't be possible to use pipe
operators to perform aggregation. But the feature is not complete (or enabled
by default) until all the operators are implemented.
##########
sql/core/src/test/resources/sql-tests/inputs/pipe-operators.sql:
##########
@@ -0,0 +1,84 @@
+-- Prepare some test data.
+--------------------------
+drop table if exists t;
+create table t(x int, y string) using csv;
+insert into t values (0, 'abc'), (1, 'def');
+
+drop table if exists other;
+create table other(a int, b int) using json;
+insert into other values (1, 1), (1, 2), (2, 4);
+
+drop table if exists st;
+create table st(x int, col struct<i1:int, i2:int>) using parquet;
+insert into st values (1, (2, 3));
+
+-- Selection operators: positive tests.
+---------------------------------------
+
+-- Selecting a constant.
+table t
+|> select 1 as x;
+
+-- Selecting attributes.
+table t
+|> select x, y;
Review Comment:
There is one on L64 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
